segfault in inadyn-mt

[Bryan Hoover]

With pid (and some minor changes; a type-o correction):

http://sourceforge.net/tracker/download.php?group_id=209367&atid=1009432&file_id=406571&aid=3270509

Regards,

Bryan

 

[Bryan Hoover]

I updated the above integration so that the pid related code supports Unicode file name and path.

http://sourceforge.net/tracker/?func=detail&aid=3277093&group_id=209367&atid=1009432

Bryan

 

[olistudent]

Thank you for your help, Bryan.

http://freetz.org/changeset/6777

Regards
Oliver

 

[RalfFriedl]

Two small suggestions:

-       if (p_dyndns->p_pidfilename) {
-               if (strlen(p_dyndns->p_pidfilename) != 0) {
+       if (p_dyndns->p_pidfilename && *p_dyndns->p_pidfilename) {

You can use fprintf to write directly to the file:

-#ifndef _WIN32
-                               if (0<snprintf(pid, 7, "%d\n", getpid()))
-#else
-                               if (0<_snprintf(pid, 7, "%d\n", _getpid()))
-#endif
-                                       obj = fwrite(pid, strlen(pid), 1, fp);
-                               fclose(fp);
+#ifndef _WIN32
+                               fprintf(fp, "%d\n", getpid());
+#else
+                               fprintf(fp, "%d\n", _getpid());
+#endif
+                               obj = fclose(fp);

While fwrite or fprintf may return write errors, in practice such a small amount of data will not be written to the file system immediately, but only at the time of the fclose, so it makes more sense to check that return value. You could also check the return values of both functions.

 

[Bryan Hoover]

I did not write the pid part of the patch, so probably, I'd not have checked the write return value at all.

But thanks. Very good point.

Bryan